[16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check #1966

AungKoKoLin1997 · 2024-03-20T02:41:27Z

This PR aims to resolve the compatibility issue between this module and other inventory adjustment related modules.
Related: #1711

@qrtl QT4850

yostashiro · 2024-03-20T03:01:27Z

stock_inventory_discrepancy/models/stock_quant.py

+        # Get the system parameter configuration
+        param = (
+            self.env["ir.config_parameter"]
+            .sudo()
+            .get_param("stock_inventory_discrepancy.inventory_discrepancy_enable")
+        )
+        if self.env.context.get("skip_exceeded_discrepancy", False) or param == "0":
            return super().action_apply_inventory()


For early returns.

Suggested change

# Get the system parameter configuration

param = (

self.env["ir.config_parameter"]

.sudo()

.get_param("stock_inventory_discrepancy.inventory_discrepancy_enable")

)

if self.env.context.get("skip_exceeded_discrepancy", False) or param == "0":

return super().action_apply_inventory()

if self.env.context.get("skip_exceeded_discrepancy", False):

return super().action_apply_inventory()

inventory_discrepancy_enable = (

self.env["ir.config_parameter"]

.sudo()

.get_param("stock_inventory_discrepancy.inventory_discrepancy_enable")

)

if inventory_discrepancy_enable == "0":

return super().action_apply_inventory()

yostashiro

Code review.

kanda999

Code review: LGTM

AungKoKoLin1997 · 2024-04-18T02:29:33Z

@OCA/stock-logistics-warehouse-maintainers
Can you please review this PR?

OCA-git-bot · 2024-06-13T03:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis

Code review.

@LoisRForgeFlow @JordiBForgeFlow

JordiBForgeFlow · 2024-06-13T06:40:52Z

@AungKoKoLin1997 From a usability perspective I think that it would be much better to add a setting in res.config.settings to enable / disable it, and document it in the readme of the module. A checkbox in res.config.settings would then update the parameter that you have proposed.

LoisRForgeFlow · 2024-06-13T06:50:04Z

@AungKoKoLin1997 From a usability perspective I think that it would be much better to add a setting in res.config.settings to enable / disable it, and document it in the readme of the module. A checkbox in res.config.settings would then update the parameter that you have proposed.

I agree

yostashiro · 2024-06-13T08:02:51Z

@AungKoKoLin1997 From a usability perspective I think that it would be much better to add a setting in res.config.settings to enable / disable it, and document it in the readme of the module. A checkbox in res.config.settings would then update the parameter that you have proposed.

@JordiBForgeFlow @LoisRForgeFlow The purpose of this update was more to pass tests from another module rather than providing additional config option to users, and as such I personally thought updating res.config.settings wouldn't be necessary (wasn't sure if there would be some users who'd like to disable the feature after installing the module with config setting when there are already other ways to bypass the check with adjusting location/warehouse settings). Having said that, if the community opts for having a field in res.config.settings, why not!

rousseldenis · 2024-06-13T08:25:09Z

The purpose of this update was more to pass tests from another module rather than providing additional config option to users

Be careful. Adding code just for tests should trigger 'warnings'. But, that said, adding a configuration that is accessible for users is always a good process to enable/disable a feature.

For several reasons:

To be able to disable process in case of bug or... without technical requirements.
To be able to deploy a solution without enabling it immediately

yostashiro · 2024-06-13T08:30:53Z

Thank you. @AungKoKoLin1997 Can you please follow up to add a configuration?

AungKoKoLin1997 · 2024-06-13T10:03:53Z

@LoisRForgeFlow @JordiBForgeFlow I added the configuration from a usability perspective. Can you please review it?

yostashiro · 2024-06-13T12:55:02Z

stock_inventory_discrepancy/models/res_config_settings.py

+        help="Enable to show line discrepancies in inventory and block validation "
+        "if the discrepancy exceeds the threshold.",


Suggested change

help="Enable to show line discrepancies in inventory and block validation "

"if the discrepancy exceeds the threshold.",

help="Block validation of the inventory adjustment if discrepancy exceeds the threshold.",

Since the setting doesn't affect the UI.

yostashiro · 2024-06-13T12:59:41Z

stock_inventory_discrepancy/views/res_config_settings_view.xml

+                    <div class="o_setting_right_pane">
+                        <label for="inventory_discrepancy_enable" />
+                        <div class="text-muted">
+                            Enable to show line discrepancies in inventory and block validation if the discrepancy exceeds the threshold.


Same as above.

yostashiro

Code review. 👍

AungKoKoLin1997 · 2024-11-15T02:17:49Z

@rousseldenis @LoisRForgeFlow @JordiBForgeFlow
I have update the PR and I believe it is in good state.
Can you please review?

AungKoKoLin1997 · 2024-11-15T02:57:42Z

@kanda999 Could you please review?

AungKoKoLin1997 · 2024-11-26T02:17:09Z

@rousseldenis I changed the approach like we did for OCA/stock-logistics-workflow#1760.
Can you please review?

yostashiro

Code review.

yostashiro · 2024-11-26T04:13:49Z

stock_inventory_discrepancy/models/__init__.py

+from . import res_config_settings
+from . import res_company


I'd suggest putting them in alphabetical order unless there is a reason not to.

…crepancy check

rousseldenis · 2024-12-11T09:27:35Z

/ocabot merge minor

OCA-git-bot · 2024-12-11T09:27:46Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1966-by-rousseldenis-bump-minor, awaiting test results.

OCA-git-bot · 2024-12-11T09:36:57Z

Congratulations, your PR was merged at 0b8d62d. Thanks a lot for contributing to OCA. ❤️

yostashiro reviewed Mar 20, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 1519072 to 0a89a0e Compare March 20, 2024 03:23

yostashiro approved these changes Mar 20, 2024

View reviewed changes

kanda999 approved these changes Apr 1, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 1, 2024

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 0a89a0e to b36eb8a Compare June 10, 2024 09:55

OCA-git-bot added the ready to merge label Jun 13, 2024

rousseldenis approved these changes Jun 13, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch 2 times, most recently from b0ba48c to 78f5ade Compare June 13, 2024 09:00

AungKoKoLin1997 requested review from yostashiro, kanda999 and rousseldenis June 13, 2024 09:57

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 78f5ade to 726edca Compare June 13, 2024 10:02

yostashiro reviewed Jun 13, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 726edca to 75165ab Compare June 14, 2024 01:26

AungKoKoLin1997 requested a review from yostashiro June 14, 2024 01:29

yostashiro approved these changes Jun 14, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 75165ab to b589a5c Compare July 1, 2024 03:37

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from b589a5c to d52a680 Compare September 2, 2024 04:22

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 059f9e8 to d85c615 Compare November 15, 2024 01:36

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from d85c615 to 477c445 Compare November 26, 2024 02:14

AungKoKoLin1997 changed the title ~~[16.0][IMP] stock_inventory_discrepancy: add system parameter configuration for enabling discrepancy check~~ [16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check Nov 26, 2024

AungKoKoLin1997 requested a review from yostashiro November 26, 2024 02:16

yostashiro approved these changes Nov 26, 2024

View reviewed changes

[IMP] stock_inventory_discrepancy: add configuration for enabling dis…

6befc0b

…crepancy check

AungKoKoLin1997 force-pushed the 16.0-imp-stock_inventory_discrepancy branch from 477c445 to 6befc0b Compare November 26, 2024 05:21

rousseldenis approved these changes Nov 26, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 11, 2024

OCA-git-bot merged commit 452540e into OCA:16.0 Dec 11, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check #1966

[16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check #1966

AungKoKoLin1997 commented Mar 20, 2024 •

edited

Loading

yostashiro Mar 20, 2024

yostashiro left a comment

kanda999 left a comment

AungKoKoLin1997 commented Apr 18, 2024

OCA-git-bot commented Jun 13, 2024

rousseldenis left a comment

JordiBForgeFlow commented Jun 13, 2024

LoisRForgeFlow commented Jun 13, 2024

yostashiro commented Jun 13, 2024

rousseldenis commented Jun 13, 2024

yostashiro commented Jun 13, 2024

AungKoKoLin1997 commented Jun 13, 2024 •

edited

Loading

yostashiro Jun 13, 2024

yostashiro Jun 13, 2024

yostashiro left a comment

AungKoKoLin1997 commented Nov 15, 2024

AungKoKoLin1997 commented Nov 15, 2024

AungKoKoLin1997 commented Nov 26, 2024

yostashiro left a comment

yostashiro Nov 26, 2024

rousseldenis commented Dec 11, 2024

OCA-git-bot commented Dec 11, 2024

OCA-git-bot commented Dec 11, 2024

		help="Enable to show line discrepancies in inventory and block validation "
		"if the discrepancy exceeds the threshold.",

	help="Enable to show line discrepancies in inventory and block validation "
	"if the discrepancy exceeds the threshold.",
	help="Block validation of the inventory adjustment if discrepancy exceeds the threshold.",

[16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check #1966

[16.0][IMP] stock_inventory_discrepancy: add configuration for enabling discrepancy check #1966

Conversation

AungKoKoLin1997 commented Mar 20, 2024 • edited Loading

yostashiro Mar 20, 2024

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

kanda999 left a comment

Choose a reason for hiding this comment

AungKoKoLin1997 commented Apr 18, 2024

OCA-git-bot commented Jun 13, 2024

rousseldenis left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Jun 13, 2024

LoisRForgeFlow commented Jun 13, 2024

yostashiro commented Jun 13, 2024

rousseldenis commented Jun 13, 2024

yostashiro commented Jun 13, 2024

AungKoKoLin1997 commented Jun 13, 2024 • edited Loading

yostashiro Jun 13, 2024

Choose a reason for hiding this comment

yostashiro Jun 13, 2024

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

AungKoKoLin1997 commented Nov 15, 2024

AungKoKoLin1997 commented Nov 15, 2024

AungKoKoLin1997 commented Nov 26, 2024

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro Nov 26, 2024

Choose a reason for hiding this comment

rousseldenis commented Dec 11, 2024

OCA-git-bot commented Dec 11, 2024

OCA-git-bot commented Dec 11, 2024

AungKoKoLin1997 commented Mar 20, 2024 •

edited

Loading

AungKoKoLin1997 commented Jun 13, 2024 •

edited

Loading